Re: [PATCH] urlfetcher: Enable Ubuntu 16.04 s390x detection

[Leno Hou <lenohou@xxxxxxxxx>]

On Tue, Apr 26, 2016 at 11:30 AM, Leno Hou <lenohou@xxxxxxxxx> wrote:

On Tue, Apr 26, 2016 at 3:37 AM, Cole Robinson <crobinso@xxxxxxxxxx> wrote:

On 04/25/2016 03:13 AM, Leno Hou wrote:
> Signed-off-by: Leno Hou <lenohou@xxxxxxxxx>
> CC: Kevin Zhao < kevin.zhaoshuai@xxxxxxxxx>
> ---
>  virtinst/urlfetcher.py | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/virtinst/urlfetcher.py b/virtinst/urlfetcher.py
> index 7f9da64..5d3f94e 100644
> --- a/virtinst/urlfetcher.py
> +++ b/virtinst/urlfetcher.py
> @@ -1158,6 +1158,10 @@ class UbuntuDistro(DebianDistro):
>      name = "Ubuntu"
>      urldistro = "ubuntu"
>
> +    _boot_iso_paths = []
> +    _hvm_kernel_paths = []
> +    _xen_kernel_paths = []
> +
>      def isValidStore(self):
>          if self.fetcher.hasFile("%s/MANIFEST" % self._url_prefix):
>              # For regular trees
> @@ -1169,6 +1173,11 @@ class UbuntuDistro(DebianDistro):
>              self._set_media_paths()
>              filename = "%s/netboot/version.info" % self._url_prefix
>              regex = "%s*" % self.name
> +        elif self.fetcher.hasFile(".disk/info") and self.arch =="s390x":
> +            self._hvm_kernel_paths += [("boot/kernel.ubuntu", "boot/initrd.ubuntu")]
> +            self._xen_kernel_paths += [("boot/kernel.ubuntu", "boot/initrd.ubuntu")]
> +            filename = ".disk/info"
> +            regex = "%s*" % self.name
>          else:
>              return False
>
>

How are you testing this? I can't find an ubuntu install tree. Is there a
public URL or install media you are using?

Thanks,
Cole

1) Problem Description:

    Virt-install command to create Ubuntu 16.04 guest fails with ' Could not find an installable

    distribution'  on s390x architecture.

2) This patch JUST enabled Ubuntu 16.04 s390x architecture detection.

     For other architecture, it's already enabled with Ubuntu 16.04 detection.

     As reference, you can download the Installation ISO and take a look at

     the install tree.

3) I've tested this patch and works fine for s390x architecture. 

Ubuntu 16.04 public download URL for all architecture, daily build.

http://cdimage.ubuntu.com/ubuntu-server/daily/current/

Thanks

Hi  Cole， Could help me to review below patch and merge to upstream? Thanks.

[PATCH V2] urlfetcher: Enable Ubuntu 16.04 s390x detection

 

-Leno Hou

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list