Re: [virt-viewer] nsis: Only search for libvirt dir when built with libvirt support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 25, 2016 at 02:48:55PM +0200, Fabiano Fidêncio wrote:
> On Mon, Apr 25, 2016 at 2:45 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
> > On Mon, Apr 25, 2016 at 02:26:40PM +0200, Fabiano Fidêncio wrote:
> >> Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> >> ---
> >>  data/virt-viewer.nsis.in | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/data/virt-viewer.nsis.in b/data/virt-viewer.nsis.in
> >> index 1853a0f..f032897 100755
> >> --- a/data/virt-viewer.nsis.in
> >> +++ b/data/virt-viewer.nsis.in
> >> @@ -177,7 +177,9 @@ Section "VirtViewer"
> >>    SetOutPath "$INSTDIR\etc"
> >>    File /r "@prefix@/etc/fonts"
> >>    File /r "@prefix@/etc/gtk-3.0"
> >> -  File /r "@prefix@/etc/libvirt"
> >> +  !if ${HaveLibvirt} == True
> >> +    File /r "@prefix@/etc/libvirt"
> >> +  !endif
> >>
> >>    CreateDirectory "$INSTDIR\etc\gtk-3.0"
> >
> >
> > Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> > I assume this is the only change needed to get libvirt-less nsis
> > installers to work? Or is there more work needed there?
> 
> The work was done more than one year ago, please, take a look on: 5159956305c3f
> This part was a leftover :-\

Ah ok, might be worth mentioning this in the commit log (that it's
something which was missed as part of commit 5159956305c3f )

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list

[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux