On 04/14/2016 04:54 AM, Mikhail Feoktistov wrote: > This patch introduces virtuozzo hypervisor support. > Here we implemented only basic functionality. > User can create/start/stop/delete containers and virtual machies. > Also we allow to change hardware configuration (basic devices) > and connect via VNC. We are very intrested in the development of > virt-manager to support all virtuozzo features. > > > Mikhail Feoktistov (2): > Add GUI and basic functionality to support virtuozzo hypervisor > Set bridged network as default for virtuozzo hypervisor > > ui/create.ui | 155 +++++++++++++++++++++++++++++++++++++++++++++- > virtManager/connect.py | 8 ++- > virtManager/connection.py | 1 + > virtManager/create.py | 58 ++++++++++++++++- > virtManager/netlist.py | 15 ++++- > virtinst/connection.py | 3 + > virtinst/guest.py | 24 ++++++- > virtinst/support.py | 2 +- > 8 files changed, 252 insertions(+), 14 deletions(-) > Cool, thanks for the patches. I haven't looked closely at them yet. However there should be test suite additions first, testing the virtinst/ bits. Can you work out some virt-install command lines to test expect virtuozzo configurations? Then add some test cases to tests/clitest.py virtinst/virt-manager has some 'magic uri' support, where you can craft a libvirt URI and virt-manager will use to make the test:/// driver appear to be a different hypervisor. See virtinst/uri.py MagicURI. The test suite uses URIs defined in tests/utils.py . For example: >>> print tests.utils.uri_kvm_s390x __virtinst_test__test:////home/crobinso/src/virt-manager/tests/testdriver.xml,predictable,qemu,domcaps=/home/crobinso/src/virt-manager/tests/capabilities-xml/kvm-x86_64-domcaps.xml,caps=/home/crobinso/src/virt-manager/tests/capabilities-xml/kvm-s390x.xml That basically says: - Use the test driver config at home/crobinso/src/virt-manager/tests/testdriver.xml , which contains a bunch of fake VM, network, storage, interface configs - Return domcapabilities as the content from /home/crobinso/src/virt-manager/tests/capabilities-xml/kvm-x86_64-domcaps.xml - Return capabilities as the content from /home/crobinso/src/virt-manager/tests/capabilities-xml/kvm-s390x.xml - Pretend to be the qemu driver (and arch s390x is taken from the capabilities output) You'll want to drop some example vz capabilities output in tests/capabilities-xml/, then teach the magic URI support to accept a 'vz' option that sets up a fake vz URI. Then for most purposes virt-install and virt-manager are set up to treat that connection as a legit connection to that hypervisor. Once you have that, you can test the virtinst/* changes in the test suite fairly easily. Let me know if you need more pointers. Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
