On Thu, Mar 24, 2016 at 01:35:18PM +0100, otheus uibk wrote: > On Thu, Mar 24, 2016 at 12:29 PM, Richard W.M. Jones <rjones@xxxxxxxxxx> > wrote: > > > On Thu, Mar 24, 2016 at 11:25:08AM +0100, otheus uibk wrote: > > > On Thu, Mar 24, 2016 at 9:58 AM, Richard W.M. Jones <rjones@xxxxxxxxxx> > > > wrote: > > > > > > > virt-what really should be able to output multiple lines. There are > > > > many cases where multiple facts apply to a single guest. > > > > > > > > > > I realize I'm new here, but uh, I beg to disagree with the word "many". > > > There are three: linux_vserver-guest and rhel5-xen*. > > > The last set (RHEL5 based xen) is very close to obsolete and can be > > treated > > > as an exception. > > > The one for linux-vserver seems to me also to be an exception and > > according > > > to commit d409914d, done for "backwards compatibility". > > > Also I should note that the test case is incomplete; linux_vserver-host > > is > > > a possibility and never made into a test-case. > > > > > > So what I am wondering is: is it *incorrect* to output the identifying > > fact > > > and immediately exit? > > > (as I do in my patch) > > > > Yes it's wrong because it breaks existing callers. > > > > Perhaps I phrased it the wrong way. > > *Excluding the multi-fact exceptions* is it ever a problem to output the > fact and immediately exit? I think you're missing the point that there might not be "a" hypervisor. It's entirely possible for the hypervisor to offer two distinct sets of services, or even to look like two different platforms (Azure + Xen). I'm wondering why this is important. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
