On 03/22/2016 10:42 AM, Eduardo Lima (Etrunko) wrote: > On 03/22/2016 08:02 AM, Pavel Grunt wrote: >> Hi, >> >> imo with the change the line is too long >> >> About the AC_SUBST calls - iirc they are defined automatically when >> pkg-config is >= 0.24 (not the case of rhel6). >> Or is it about something else (why just _LIBS and not _CFLAGS) ? >> > > About line being to long it is easily fixed by breaking the line. This > patch is only here because when I reviewed the original patch, it wal > already merged. > > About calling AC_SUBST for _LIBS, only _CFLAGS varible is touched, so it > is only required for the latter. I will provide more details in the > commit message. > Forgot to add that about RHEL6, it does not matter anyway, as virt-viewer dropped Gtk+ 2.0 support recently. -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etrunko@xxxxxxxxxx _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
