On Mon, Feb 29, 2016 at 6:27 PM, Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx> wrote: > On 02/26/2016 07:38 PM, Fabiano Fidêncio wrote: >> Let's take advantage of GResource for loading ui files in a better and >> cleaner way than virt_viewer_util_load_ui() was doing. >> It also brings the benefit, at least for developers, of being able to >> test ui changes without having to "make install" virt-viewer. >> > > General question, does this mean that those XML files don't need to be > installed anymore? Yes, they end up compiled right into the executable.. > If so, you might also remove them from Makefile. We still have to distribute them. > > Otherwise patch looks good. I don't kwnow much about GResources, so it > might be interesting to listen from more experienced people. Thanks for the review. _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
