On Thu, Jan 28, 2016 at 11:27:14AM -0500, Cole Robinson wrote: > On 01/27/2016 09:51 PM, Jim Fehlig wrote: > > Extend the domcapabilities regex to include SUSE's OVMF > > file naming convention. > > > > Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> > > --- > > virtinst/domcapabilities.py | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/virtinst/domcapabilities.py b/virtinst/domcapabilities.py > > index 86bdfe8..f074b4e 100644 > > --- a/virtinst/domcapabilities.py > > +++ b/virtinst/domcapabilities.py > > @@ -101,6 +101,7 @@ class DomainCapabilities(XMLBuilder): > > "x86_64": [ > > ".*OVMF_CODE\.fd", # RHEL > > ".*ovmf-x64/OVMF.*\.fd", # gerd's firmware repo > > + ".*ovmf-x86_64-.*", # SUSE > > ], > > "aarch64": [ > > ".*AAVMF_CODE\.fd", # RHEL > > > > ACK and pushed, thanks! Patches like this are definitely appreciated for > upstream, since ideally virt-manager.git works out of the box on any distro. > > "gerd's firmware repo" probably sounds weird, but it's the recommended way to > consume ovmf on fedora, since we can't package it yet due to Fedora's license > policies. Details here if you're curious: > > https://fedoraproject.org/wiki/Using_UEFI_with_QEMU > > Unfortunately having to hardcode this stuff in the tools is suboptimal, > hopefully long term we figure out a better solution at the libvirt level. I > blogged a bit about it a few weeks ago: > > http://blog.wikichoon.com/2016/01/uefi-support-in-virt-install-and-virt.html > > also ccing rjones since he has similar code in libguestfs that may need to be > extended Thanks Cole. Jim: What's the full path to the OVMF files on SUSE? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
