On 12/03/2015 07:26 AM, Abhijeet Kasurde wrote: > This fix adds a user dialog box for confirmation specific to disk, > also deletes disk from storage. > > Signed-off-by: Abhijeet Kasurde <akasurde@xxxxxxxxxx> > --- Thanks for the patch! For reference there's a bug for this: https://bugzilla.redhat.com/show_bug.cgi?id=1058051 Unfortunately this isn't sufficient. The main problem is it ties together 'delete the media' with 'remove the device from the VM'. There needs to be an option to just remove the device and leave the media intact. I think we should find a way to share bits of delete.py for this purpose. It already handles storage deletion, and takes into account bits like if the disk is readonly, shareable, or in use by other VMs. We would need to use a different dialog but the guts would be shared. Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
