On 11/12/2015 08:48 PM, Kevin Zhao wrote: > Add console target "sclp" for s390x ,since the newest Distro guests has > supported the console target, solve some console issues in s390x.Also > modified the test xml cover this change. > --- > tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml | 2 ++ > virtinst/guest.py | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml b/tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml > index 3cccaca..7507641 100644 > --- a/tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml > +++ b/tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml > @@ -31,6 +31,8 @@ > <mac address="00:11:22:33:44:55"/> > </interface> > <console type="pty"/> > + <target type="sclp"/> > + </console> > <watchdog model="diag288" action="reset"/> > </devices> > </domain> > diff --git a/virtinst/guest.py b/virtinst/guest.py > index 959ab7e..88b2994 100644 > --- a/virtinst/guest.py > +++ b/virtinst/guest.py > @@ -628,6 +628,8 @@ class Guest(XMLBuilder): > > dev = VirtualConsoleDevice(self.conn) > dev.type = dev.TYPE_PTY > + if self.os.is_s390x(): > + dev.target_type = "sclp" > self.add_device(dev) > > def add_default_video_device(self): > Thanks, pushed now with regenerated test output since you missed a file - Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
