Hey, (did not get 0/6 and 1/6 for some reason but they are in the mailing list archives https://www.redhat.com/archives/virt-tools-list/2015-November/msg00041.html ) On Wed, Nov 04, 2015 at 12:32:43PM -0200, Eduardo Lima (Etrunko) wrote: > After removing m4/.gitignore file in previous patch, I started getting > the following error when running autogen.sh. > > ln: failed to create symbolic link ‘m4/intltool.m4’: No such file or directory > cp: cannot create regular file ‘m4/intltool.m4’: No such file or directory > intltoolize: cannot copy '/usr/share/aclocal/intltool.m4' to 'm4/intltool.m4' > > The problem is that intltoolize requires te m4/ directory to be present, > and this directory is actually created by running autoreconf, so it > should be called before intltoolize. Having a .gitignore in an otherwise empty directory is how you usually make sure git a directory exists in a git repository, so yes, the directory no longer is always present after the previous commit, and code relying on the directory being present is going to have issues. Regardless of that, this patch is correct as intltoolize's documentation says it should be called after gettextize (now autopoint, which is called by autoreconf). ACK. > > Signed-off-by: Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx> > --- > autogen.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/autogen.sh b/autogen.sh > index b8d3c4d..a688ad4 100755 > --- a/autogen.sh > +++ b/autogen.sh > @@ -27,8 +27,8 @@ fi > # exists at all times :-( > touch ChangeLog AUTHORS > > -intltoolize --force > autoreconf -vfi > +intltoolize --force > > cd $THEDIR > > -- > 2.4.3 > > _______________________________________________ > virt-tools-list mailing list > virt-tools-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/virt-tools-list
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
