Christophe pointed out that the message was not clear enough.
So I changed it to:
window: Standardize "Leave Fullscreen" behaviour
Historically fullscreen mode used to be an app-level option (you could
only have *all* windows fullscreen or *all* windows non-fullscreen). At
some point per-window fullscreen was introduced, but the startup
fullscreen remained with the old (app-level) behaviour.
According to the multimonitor requirements[0], item D5, the --fullscreen
behaviour needs to be changed to match the per-window fullscreen
behaviour, what is done by this patch.
[0]:
https://www.redhat.com/archives/virt-tools-list/2015-June/msg00074.html
Resolves: rhbz#1275248
On Tue, Oct 27, 2015 at 11:55 AM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote:
> Historically fullscreen mode used to be an app-level option (you could
> only have *all* windows fullscreen or *all* windows non-fullscreen). At
> some point per-window fullscreen was introduced, but the startup
> fullscreen remained with the old (app-level) behaviour.
> According to the multimonitor requirements[0], item D5, this behaviour
> needs to be changed.
>
> [0]:
> https://www.redhat.com/archives/virt-tools-list/2015-June/msg00074.html
>
> Resolves: rhbz#1275248
> ---
> src/virt-viewer-window.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> index a1b9940..5d9f3d4 100644
> --- a/src/virt-viewer-window.c
> +++ b/src/virt-viewer-window.c
> @@ -784,12 +784,7 @@ virt_viewer_window_set_fullscreen(VirtViewerWindow *self,
> if (fullscreen) {
> virt_viewer_window_enter_fullscreen(self, -1);
> } else {
> - /* leave all windows fullscreen state */
> - if (virt_viewer_app_get_fullscreen(self->priv->app))
> - g_object_set(self->priv->app, "fullscreen", FALSE, NULL);
> - /* or just this window */
> - else
> - virt_viewer_window_leave_fullscreen(self);
> + virt_viewer_window_leave_fullscreen(self);
> }
> }
>
> --
> 2.4.3
>
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
