On Mon, 2015-10-12 at 10:26 +0100, Daniel P. Berrange wrote: > On Fri, Oct 09, 2015 at 04:15:13PM -0500, Jonathon Jongsma wrote: > > Unfortunately, there was no single-header include for the GTK+ library > > until just recently (spice-client-gtk.h), so this requires bumping the > > spice-gtk version requirement to a unreleased git version. > > IIUC this is going to prevent virt-viewer being built against existing > released of spice. I think this is a rather unpleasant API break for > SPICE to force on client programs. > > I would really expect there to be several releases where SPICE provided > the new single-header that apps could use, while *also* allowing apps > to continue to include the more specific headers. ie, give apps some > grace time to switch over to the new style. Can you try and re-visit > this in SPICE first. > > Regards, > Daniel Actually, the only changes I have pushed to spice are those that: - add this new spice-client-gtk.h master header - produce a compiler #warning when including one of the sub-headers So, at the moment, it is still possible to build virt-viewer against both released and unreleased (git master) spice-gtk. In the latter case, we'll just get compile warnings. This patch adds a dependency on git master to try to avoid those warnings. But we can delay this patch and simply live with the warnings for a little while if that's what people prefer. Jonathon _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
