On Thu, Oct 8, 2015 at 4:29 PM, Marc-André Lureau <mlureau@xxxxxxxxxx> wrote: > > > ----- Original Message ----- >> As, in theory, file ids are stables, seems that we have been using the >> wrong id for remote-viewer,exe since forever. > > I don't think so, file association used to work. > > More likely the path changed. > >> That's what msidump shows: >> >> ffidenci@cat ~/src/upstream/virt-viewer $ mkdir dump/ >> ffidenci@cat ~/src/upstream/virt-viewer $ cd dump/ >> ffidenci@cat ~/src/upstream/virt-viewer/dump $ msidump >> ../data/virt-viewer-x86-3.0.msi >> Exporting table _SummaryInformation... >> Exporting table _ForceCodepage... >> Exporting table AdminExecuteSequence... >> Exporting table AdvtExecuteSequence... >> Exporting table Component... >> Exporting table FeatureComponents... >> Exporting table CreateFolder... >> Exporting table AppSearch... >> Exporting table Property... >> Exporting table File... >> Exporting table ServiceInstall... >> Exporting table Error... >> Exporting table InstallExecuteSequence... >> Exporting table InstallUISequence... >> Exporting table RegLocator... >> Exporting table Feature... >> Exporting table CustomAction... >> Exporting table Icon... >> Exporting table Upgrade... >> Exporting table RemoveFile... >> Exporting table Shortcut... >> Exporting table Directory... >> Exporting table AdminUISequence... >> Exporting table Registry... >> Exporting table LaunchCondition... >> Exporting table Media... >> Exporting table Binary... >> Exporting table ServiceControl... >> Exporting table Signature... >> Exporting table MsiFileHash... > > You could cut it "[...]".. > >> ffidenci@cat ~/src/upstream/virt-viewer/dump $ grep >> "fil808B4A5BAB4ACD727D3823632E798743" File.idt >> ffidenci@cat ~/src/upstream/virt-viewer/dump $ grep >> "fil808B4A5BAB4ACD727D3823632E798743" Registry.idt >> reg29E29C5608128A0192FB9DC3C18562A6 0 >> VirtViewer.vvfile\shell\open\command >> "[#fil808B4A5BAB4ACD727D3823632E798743]" "%1" CProgIds >> ffidenci@cat ~/src/upstream/virt-viewer/dump $ grep "remote-viewer.exe" >> File.idt >> fil610DF9E49759B1DEC646290195F96F8A cmp7677A8696936707272DCA43B1BF26760 >> remote-viewer.exe 855735 512 837 >> >> So, let's use the correct id (fil610DF9E49759B1DEC646290195F96F8A) from >> now on. >> >> Related: rhbz#1146016 >> --- >> data/virt-viewer.wxs.in | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/data/virt-viewer.wxs.in b/data/virt-viewer.wxs.in >> index 2ed3b93..b7ea1e0 100644 >> --- a/data/virt-viewer.wxs.in >> +++ b/data/virt-viewer.wxs.in >> @@ -67,7 +67,7 @@ >> <Component Id="CProgIds" Guid="89D6F46D-9C5E-4D65-8456-58FC361E553E"> >> <ProgId Id='VirtViewer.vvfile' Description='VirtViewer connection >> file'> >> <Extension Id='vv' ContentType='application/x-virt-viewer'> >> - <Verb Id='open' Command='Open' >> TargetFile='fil808B4A5BAB4ACD727D3823632E798743' Argument='"%1"' /> >> + <Verb Id='open' Command='Open' >> TargetFile='fil610DF9E49759B1DEC646290195F96F8A' Argument='"%1"' /> >> <MIME ContentType="application/x-virt-viewer" Default="yes"/> >> </Extension> >> </ProgId> >> -- >> 2.4.3 > > If association works now, ack Did the changes and pushed as 097e1f6..69e29ac Best Regards, _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
