[virt-viewer][PATCH 2/2] coverity: result is not floating-point

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Coverity says:
Result is not floating-point (UNINTENDED_INTEGER_DIVISION)
interger_division: Dividing integer expressions "preferred->width * 100"
and "zoom", and then converting the integer quotient to type double. Any
remainder, or fractional part of the quotient, is ignored.
---
 src/virt-viewer-display.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c
index 3efe24c..8431ae4 100644
--- a/src/virt-viewer-display.c
+++ b/src/virt-viewer-display.c
@@ -819,8 +819,8 @@ void virt_viewer_display_get_preferred_monitor_geometry(VirtViewerDisplay* self,
     if (virt_viewer_display_get_zoom(VIRT_VIEWER_DISPLAY(self))) {
         guint zoom = virt_viewer_display_get_zoom_level(VIRT_VIEWER_DISPLAY(self));
 
-        preferred->width = round(preferred->width * NORMAL_ZOOM_LEVEL / zoom);
-        preferred->height = round(preferred->height * NORMAL_ZOOM_LEVEL / zoom);
+        preferred->width = round(preferred->width * NORMAL_ZOOM_LEVEL / (double) zoom);
+        preferred->height = round(preferred->height * NORMAL_ZOOM_LEVEL / (double) zoom);
     }
 }
 
-- 
2.4.3

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list



[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux