Re: [PATCH virt-viewer] Show window after its default and preferred sizes are set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It seems OK to me. Let's get it upstream.


On Wed, 2015-07-22 at 17:24 +0200, Pavel Grunt wrote:
> Under some circumstances (Xfce desktop environment, gtk3 client,  RHEL6
> guest having two monitors running locally) it is possible to create
> a loop of resizing windows. It is caused by size request like 1x1 sent
> to the guest. These request are created because _window_queue_resize()
> is called when the window is being shown.
> To avoid the problem, call gtk_widget_show() after its preferred and
> default sizes are set.
> 
> Resolves:
> https://bugs.freedesktop.org/show_bug.cgi?id=91405
> ---
>  src/virt-viewer-window.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> index ec20502..baf565d 100644
> --- a/src/virt-viewer-window.c
> +++ b/src/virt-viewer-window.c
> @@ -1343,13 +1343,13 @@ virt_viewer_window_show(VirtViewerWindow *self)
>      if (self->priv->display)
>          virt_viewer_display_set_enabled(self->priv->display, TRUE);
>  
> -    gtk_widget_show(self->priv->window);
> -
>      if (self->priv->desktop_resize_pending) {
>          virt_viewer_window_queue_resize(self);
>          self->priv->desktop_resize_pending = FALSE;
>      }
>  
> +    gtk_widget_show(self->priv->window);
> +
>      if (self->priv->kiosk)
>          virt_viewer_window_enable_kiosk(self);
>  


_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list



[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux