Hi Christophe, On Thu, 2015-07-23 at 17:28 +0200, Christophe Fergeau wrote: > Hey, > > On Mon, Jun 29, 2015 at 01:18:19PM +0200, Pavel Grunt wrote: > > Avoid failing configure with an older spice-protocol > > To be honest, took me a while to understand what this commit was meant > to achieve :-/ > Maybe a more descriptive changelog would help: > > "When neither --with-spice-gtk=yes nor --with-spice-gtk=no is used, > spice-gtk is supposed to be automatically enabled/disabled depending > on its availability. However, this is not perfectly working as once > spice-gtk has been detected as available, configure will fail if > spice-protocol or spice-controller ar too old. In this case, spice-gtk > support should just be disabled rather than configure failing" > Ok, I will use your version. Thank you, Pavel > Maybe this is too verbose ;) > > > > > --- > > configure.ac | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/configure.ac b/configure.ac > > index 3399129..df0053d 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -180,7 +180,8 @@ AC_ARG_WITH([spice-gtk], > > > > AS_IF([test "x$with_spice_gtk" != "xno"], > > [PKG_CHECK_MODULES(SPICE_GTK, > > - [spice-client-gtk-$SPICE_GTK_API_VERSION >= > > $SPICE_GTK_REQUIRED], > > + [spice-client-gtk-$SPICE_GTK_API_VERSION >= > > $SPICE_GTK_REQUIRED > > + spice-controller spice-protocol >= > > $SPICE_PROTOCOL_REQUIRED], > > [have_spice_gtk=yes], [have_spice_gtk=no])], > > The individual checks for spice-protocol and spice-controller could be > removed from the block which comes below, but this is all revamped in > the next commit anyway, so no big deal. > > ACK. > > Christophe _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
