Howdy! ----- Original Message ----- > From: "Fabiano Fidêncio" <fidencio@xxxxxxxxxx> > To: virt-tools-list@xxxxxxxxxx > Cc: "Fabiano Fidêncio" <fidencio@xxxxxxxxxx> > Sent: Thursday, July 16, 2015 2:04:33 PM > Subject: [virt-viewer][PATCH] Revert "virt-viewer: set keepAlive on libvirt connection" > > This reverts commit 08378ec4dc3623792c64a3bae6279eac1c3c153e. > > The commit in question was done in order to fix rhbz#1164052, but has > been proven that it's not necessary depending on the libvirt version on > the remote host. > Considering we don't want to keep a workaround that can, actually, hide > a proper bug that must be fixed (or in virt-viewer, or elsewhere), > reverting this patch seems the safest option for now. Jonathon asked me on IRC: 11:08 <~ jjongsma> fidencio, any additional context about that patch reverting the keepalive? 11:08 <~ jjongsma> which versions is it unnecessary for? How did you find that? etc. 11:13 <@ fidencio> jjongsma: hmmm. I will add more info there. So, to be added to the commit message: The patch was not necessary when connecting to a rhel6 host (libvirt-0.10.2-54) neither connecting to a fedora22 host (libvirt-1.2.13.1-2). The problem could be reproduce on rhel7 host (libvirt-1.2.17-1). And these are the systems that I have installed on my remote host machine. Best Regards, -- Fabiano Fidêncio _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
