On 06/19/2015 03:33 AM, Giuseppe Scrivano wrote: > Pavel Hrdina <phrdina@xxxxxxxxxx> writes: > >> Similarly as in commit 95cda553, just remove the dependency on qemu-kvm >> package for RHEL builds. We don't need it, becase libvirt-daemon-kvm >> will handle this dependency correctly for us even in case that only >> qemu-kvm-rhev is present. >> >> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1046651 >> >> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> >> --- >> virt-manager.spec.in | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/virt-manager.spec.in b/virt-manager.spec.in >> index cb6579f..ebd17ca 100644 >> --- a/virt-manager.spec.in >> +++ b/virt-manager.spec.in >> @@ -12,7 +12,6 @@ >> >> %if 0%{?rhel} >> %define preferred_distros "rhel,fedora" >> -%define kvm_packages "qemu-kvm" >> %define stable_defaults 1 >> %endif > > with this patch virt-manager won't ask to install kvm packages when not > found. I think it is OK, but let's see what Cole thinks about it. > Patch is fine IMO, the kvm_packages vs libvirt_packages split is from a time before the libvirt-daemon-kvm convenience package. Just tracking libvirt-daemon-kvm simplifies our life, so ACK. > If we won't use "kvm_packages", we should also remove the code using it > (grep for kvm_package_names and kvm-package-names). > Other distros may still want this split, since the libvirt_packages will trigger additional behavior to try and startup libvirtd. Dunno if other distros are even using it though... debian/ubuntu probably solve this with suggests/recommends dependencies - Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
