Hi
--
On Mon, Jun 8, 2015 at 6:54 PM, <sstutsma@xxxxxxxxxx> wrote:
From: Sandy Stutsman <sstutsma@xxxxxxxxxx>
If ALLUSERS is not specified in virt-viewer.wxs.in, the resulting msi fails
to do a proper perMachine install. This patch explicitly sets ALLUSERS=1.
Because previous installations are a mix of perUser and perMachine,this
installation will *NOT* upgrade them.
What do you mean by "a mix" ? This property isn't set afaik, but it could be set via msiexec argument (and possibly by install option). I think this just changes the default, but that's not really something that is radically changing the package and breaking updates imho. You could probably still install with ALLUSERS=0 anyway after.
Those packages must be removed manually before installing this one.
---
data/virt-viewer.wxs.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/data/virt-viewer.wxs.in b/data/virt-viewer.wxs.in
index c90d70e..bf32868 100644
--- a/data/virt-viewer.wxs.in
+++ b/data/virt-viewer.wxs.in
@@ -55,6 +55,7 @@
<Property Id="ARPNOREPAIR" Value="1"/>
<Property Id="ARPPRODUCTICON" Value="virt-viewer.ico"/>
<Property Id="ARPURLINFOABOUT" Value="http://www.virt-tools.org/about"/>
+ <Property Id="ALLUSERS" Value="1"/>
I would rather use WiX <Package InstallScope="perMachine"/> attribute.
<Upgrade Id="$(var.UpgradeCode)">
<UpgradeVersion Minimum="$(var.Version)" _OnlyDetect_="yes" Property="NEWERVERSIONDETECTED"/>
<UpgradeVersion Minimum="0.0.0" Maximum="$(var.Version)" IncludeMinimum="yes" IncludeMaximum="no" Property="OLDERVERSIONBEINGUPGRADED"/>
--
1.9.5.msysgit.0
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
--
Marc-André Lureau
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
