Hey, On Tue, Jun 02, 2015 at 03:23:53PM +0100, Daniel P. Berrange wrote: > On Tue, Jun 02, 2015 at 04:18:58PM +0200, Christophe Fergeau wrote: > > This was added in commit 3232ddb and mistakenly removed in 28a6bd6 > > Without this added dash, remote-viewer --version gives something like > > "3.01" with a '1' buildid. > > No, that was not a mistake. We do /not/ want a '-' in the buildid > value, because we use that value to create WINDOWS_PRODUCTVERSION > variable which should not include '-'. Ah good point, I missed that. > > I think you should change the remote-viewer remote_viewer_version() > method to print the '-' This would not be enough, BUILDID is used in 6 different places. I'll make sure to only append the '-' to BUILDID if it's set, and not to the buildid variable in configure.ac Christophe
Attachment:
pgp4kpcX9FiEX.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
