Cole Robinson <crobinso@xxxxxxxxxx> writes: >> + def check_defaults(self): >> + if not self._hv_supported(): >> + self.features.hyperv_relaxed = None >> + self.features.hyperv_vapic = None >> + self.features.hyperv_spinlocks = None >> + self.features.hyperv_spinlocks_retries = None >> + for i in self.clock.timers: >> + if i.name == "hypervclock": >> + self.clock.remove_timer(i) >> + >> def _set_feature_defaults(self): >> if self.os.is_container(): >> self.features.acpi = None >> > > ACK, but can you add a comment to check_defaults explaining how it's used: > virt-manager only, to reset any defaults that may have changed through manual > intervention via the customize wizard. I know I'll eventually forget... Thanks for the quick review. I have pushed the patch with the comment. Giuseppe _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
