Hi Cole,
It seems that commit 5219e49e caused virt-manager to infinite recursion
in certain cases.
e.g: create new vm -> local install media -> select an iso(says fedora
21 Server), Then the virt-manager hangs.
Not sure whether the following changes make sense, just FYI:
(actually I dont know which scenario meets the both of condition: 'if
nothing is selected' and 'the widget is a combo box with a text entry')
diff --git a/virtManager/uiutil.py b/virtManager/uiutil.py
index 82d2c1d..40a7964 100644
--- a/virtManager/uiutil.py
+++ b/virtManager/uiutil.py
@@ -77,10 +77,10 @@ def get_list_selection(widget, column=0,
check_visible=False):
return the value of that.
"""
row = get_list_selected_row(widget, check_visible=check_visible)
- if row is not None:
+ if row:
return row[column]
- if hasattr(widget, "get_has_entry"):
+ if row is not None and hasattr(widget, "get_has_entry"):
if widget.get_has_entry():
return widget.get_child().get_text().strip()
Lin
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
