On Mon, 2015-04-20 at 14:05 -0400, Pavel Grunt wrote: > > > > On Mon, 2015-04-20 at 13:39 -0400, Pavel Grunt wrote: > > > > > > > > This is a second attempt to fix an issue where extra displays are > > > > sometimes > > > > opened when starting virt-viewer in --full-screen mode. This can > > > > happen when > > > > the guest has more displays enabled than the client requests. My > > > > first attempt > > > > involved changes in spice-server to prevent sending out "old" > > > > monitor > > > > configurations at startup if the client had already sent a new > > > > config. In > > > > contrast, this patch attempts to deal with the issue from the > > > > client > > > > side. It > > > > does this by sending out the monitor configuration and then > > > > waiting > > > > for a > > > > certain amount of time to let the server reconfigure itself > > > > before > > > > creating any > > > > display windows, etc. If the guest does not configure itself in > > > > time, > > > > it just > > > > gives up and creates displays to match the current state of the > > > > guest. > > > > > > > > The timeout is rather arbitrary. In this patch it's set to 2 > > > > seconds, > > > > but I > > > > suspect that's far too low to be generally useful. I've so far > > > > only > > > > tested it > > > > with a host and client on different machines on a local network. > > > > I > > > > think the > > > > timeout will probably need to be increased to deal with slower > > > > and > > > > higher > > > > latency networks. > > > > > > > > Jonathon Jongsma (4): > > > > SessionSpice: keep a list of display channels > > > > SessionSpice: save initial fullscreen configuration > > > > SessionSpice: Keep track of auto conf state > > > > Fullscreen auto-conf: wait for server to be configured > > > > > > > > src/virt-viewer-session-spice.c | 162 > > > > +++++++++++++++++++++++++++++++++++----- > > > > 1 file changed, 145 insertions(+), 17 deletions(-) > > > > > > > > > > Hi Jonathon, > > > > > > I was using your patches and I noticed strange behavior with > > > two-monitors-guests (more reproducible with win7). > > > When I leave fullscreen both display changes resolution from > > > 1920x1080 to 1010x555, one of the > > > windows also changes width to half of size of my monitor. Also both > > > windows has wrong zoom level > > > after I leave fullscreen and it is probably the root cause of the > > > problems - I will look at it > > > more properly asap. > > > > > > Regards, > > > Pavel > > > > > > > > > > > > Hmm, strange. This only happens with my patches? I'll try to > > reproduce > > here as well. Thanks. > > > > Jonathon > > > > I cannot reproduce it on git master. My client/host is Fedora Rawhide > and it is much harder to reproduce it with linux as a guest. > > Pavel Hmm, I was able to reproduce the half-size window one time, but have been unsuccessful at reproducing it since then. I'll keep trying. I can regularly reproduce an issue where the second display is at a different zoom level, but I can reproduce that with git master as well, so I don't think that's related. Jonathon _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
