On 04/09/2015 05:34 AM, Pavel Grunt wrote: > Hey, > >> >> Hey, >> >> On Wed, Apr 08, 2015 at 09:22:37AM +0200, Pavel Grunt wrote: >>> diff --git a/configure.ac b/configure.ac >>> index 45b894d..f445b84 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -203,7 +203,18 @@ AS_IF([test "x$with_ovirt" != "xno"], >>> [have_ovirt=no]) >>> >>> AS_IF([test "x$have_ovirt" = "xyes"], >>> - [AC_DEFINE([HAVE_OVIRT], 1, [Have libgovirt?])], >>> + [AC_DEFINE([HAVE_OVIRT], 1, [Have libgovirt?])] >>> + [SAVED_CFLAGS=$CFLAGS >>> + SAVED_LIBS=$LIBS >>> + CFLAGS=$OVIRT_CFLAGS >>> + LIBS=$OVIRT_LIBS >> >> >> I don't know if the $xxx variables should be quoted with "" Required for shell? No. Quotes are needed to suppress word splitting and globbing, but variable assignment is not subject to either of those in the first place. So I often omit them in my own code (I prefer smaller files). > > You are right, they are quoted in similar cases. Required for consistency? Yes, being consistent is nice. So I will use quotes, even when redundant, if the prevailing style of a file also uses them. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
