On 04/02/2015 06:04 PM, Marc-André Lureau wrote:
> Hi,
>
> This is a small series introducing the vmport feature configuration
> with virt-install (the patches are yet to be reviewed for libvirt).
> By default, vmport will be disable when the VM is using Spice, since
> it prevents a Spice client from switching between absolute and
> relative pointer.
>
Thanks for the patches! I'll push when the libvirt patches land.
I also added this additional commit to make sure xmlparse.py doesn't fail with
older libvirt.
commit 7b75f98b6c0174ddbedfa475f4c0069754bdad73
Author: Cole Robinson <crobinso@xxxxxxxxxx>
Date: Fri Apr 3 11:18:47 2015 -0400
tests: Fix vmport test on older libvirt
diff --git a/tests/xmlparse.py b/tests/xmlparse.py
index 5077617..a900530 100644
--- a/tests/xmlparse.py
+++ b/tests/xmlparse.py
@@ -40,8 +40,10 @@ class XMLParseTest(unittest.TestCase):
actualXML = guest.get_xml_config()
utils.diff_compare(actualXML, expect_out=expectXML)
- def _alter_compare(self, actualXML, outfile):
+ def _alter_compare(self, actualXML, outfile, support_check=None):
utils.diff_compare(actualXML, outfile)
+ if (support_check and not conn.check_support(support_check)):
+ return
utils.test_create(conn, actualXML)
def testRoundTrip(self):
@@ -228,7 +230,8 @@ class XMLParseTest(unittest.TestCase):
check("nosharepages", False, True)
check("locked", False, True)
- self._alter_compare(guest.get_xml_config(), outfile)
+ self._alter_compare(guest.get_xml_config(), outfile,
+ support_check=conn.SUPPORT_CONN_VMPORT)
def testAlterMinimalGuest(self):
guest, outfile = self._get_test_content("change-minimal-guest")
diff --git a/virtinst/support.py b/virtinst/support.py
index f7beeb1..9dab7d8 100644
--- a/virtinst/support.py
+++ b/virtinst/support.py
@@ -304,7 +304,7 @@ SUPPORT_CONN_DOMAIN_CAPABILITIES = _make(
run_args=(None, None, None, None))
SUPPORT_CONN_VIDEO_NEW_RAM_OUTPUT = _make(version="1.2.11")
SUPPORT_CONN_VMPORT = _make(
- version="1.2.15", hv_version={"qemu": "2.2.0"})
+ version="1.2.15", hv_version={"qemu": "2.2.0", "test": 0})
# Domain checks
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
