Re: [PATCH virt-viewer] virt-viewer-app: Set hotkeys when app is constructed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 30, 2015 at 08:16:11AM -0400, Pavel Grunt wrote:
> Hey,
> > 
> > Hey,
> > 
> > For what it's worth, a bit more details in the log about what is
> > causing
> > the bug/why this commit is fixing it would be useful. From a quick
> > look,
> > this might be the call to virt_viewer_app_set_enable_accel() which
> > will
> > be overridden during property settings? I'd need to test to be sure.
> > Or maybe I'm missing something obvious here :)
> > 
> > Christophe
> > 
> 
> As you said, it is related to virt_viewer_app_set_enable_accel(). I don't know why it was moved to virt_viewer_app_init(). In _init() we don't have the display which can react to the "enable-accel" notify.
> However in constructed() we have the display and thanks to it we can change the accel.
> 
> I will send v2...

If an improved log would be the only change, feel free to push directly
with some mention in the log of virt_viewer_app_set_enable_accel()

Christophe

Attachment: pgpG37Jg55KRk.pgp
Description: PGP signature

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list

[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux