On Wed, Mar 11, 2015 at 6:10 PM, Jonathon Jongsma <jjongsma@xxxxxxxxxx> wrote: > I discussed this with Fabiano on IRC a little bit, and my feeling is > that this is not the ideal place to handle this case. However, when > trying to write a patch that seemed more "correct" to me > (http://paste.fedoraproject.org/196405/1833114/), it introduced a > regression[1] that does not occur with Fabiano's patch. So I guess I'd > tentatively ACK Fabiano's patch since it appears to work without > regressions. The alternative is to spend the time investigating why my > patch fails, but I suspect that will be a lot of work, and the behavior > may be different on gtk2 vs gtk3, etc. Anyone else have opinions on the > matter? > > Jonathon > > [1] When virt-viewer started up, the display windows would appear at the > correct size and then immediately shrink to a very small size. This is a > fairly common regression that keeps cropping up from time to time. > Perhaps some day we can re-factor this whole thing to make it less > susceptible to these sorts of regressions, but I fear that may be a lot > of work, and may not even be possible (especially while we have to > support both gtk2 and gtk3)... As we had no objections in 5 days, I have pushed the patch to the git master. Best Regards, -- Fabiano Fidêncio _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
