Hey Marc-André! On Wed, Mar 4, 2015 at 7:01 PM, Marc-André Lureau <marcandre.lureau@xxxxxxxxx> wrote: > Hi > > A small series to do basic configuration of folder sharing with Spice: > > - dialog allows to enable/disable share folder, change folder, and set > read-only > - shared folder is disabled by default > - default shared folder is spice-gtk default (~/Public) > - no settings are saved, and it's not configurable by .vv files either > > V2: > - fixes missing label in a patch, and a compiler warning > > Marc-André Lureau (10): > misc: add a missing "static" for function > Add a few session properties for share folder > Bump spice-gtk to 0.28 > spice: sync share folder preferences with session > spice: enable/disable share folder > Add preferences dialog UI file > Show preferences dialog > Sync preferences widgets with session properties > Add virt_viewer_session_can_share_folder() > Enable share folder widgets if supported by session > > configure.ac | 2 +- > src/Makefile.am | 1 + > src/virt-viewer-app.c | 81 +++++++++++++++++++++++- > src/virt-viewer-app.h | 1 + > src/virt-viewer-preferences.xml | 134 ++++++++++++++++++++++++++++++++++++++++ > src/virt-viewer-session-spice.c | 45 +++++++++++++- > src/virt-viewer-session.c | 70 +++++++++++++++++++++ > src/virt-viewer-session.h | 2 + > src/virt-viewer-window.c | 7 +++ > src/virt-viewer.xml | 9 +++ > 10 files changed, 349 insertions(+), 3 deletions(-) > create mode 100644 src/virt-viewer-preferences.xml > > -- > 2.1.0 > > _______________________________________________ > virt-tools-list mailing list > virt-tools-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/virt-tools-list So, with this email I'll address the problems I had with the usability and I've tested against a Windows 7 machine, using the spice-webdav binary from https://elmarco.fedorapeople.org/spice-webdavd-x86-2.0.msi. The code review will be addressed in each patch if there is something to be mentioned .... 1) As soon I run the map.driver.bat I can see these warnings: (remote-viewer:26077): GSpice-WARNING **: read error: Stream is already closed 2) Read-Only: It works in the sense that, if you try to delete a file/folder on the guest-side, it won't be deleted on the client-side. On the other hand for a few times that I've tried to delete a folder/file I had the following issue: - Folder is deleted on guest-side (iow, it seems to be deleted), but it is not deleted on client-side - Folder takes forever to be deleted (or to show an error) and then the "Explorer"(?) just crashed and I had to reboot my machine :-( - Folder is not deleted, but a way cryptic error is shown in the guest. Also, enabling and disabling the read-only flag seemed to make the guest a bit confused. I didn't go further debugging it at this moment. 3) Preferences UI: I don't know the details of the phodav implementation, but, if possible, I'd prefer a way to share more than one folder at the same time. For this, a different UI would be appreciated (something with a button to: "share a folder" and then a list of shared-folders and theirs privacy settings Best Regards, -- Fabiano Fidêncio _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
