Re: [PATCH] fix source name attribute for gluster volumes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ok, here it is.

2015-01-29 18:26 GMT+03:00 Cole Robinson <crobinso@xxxxxxxxxx>:
Ah okay, that pool output explains things, I didn't realize there could be a
dir path that's more than just '/'

Can you provide an example volume XML from that pool as well? With that I will
apply your patch and make sure the test suite covers this case.

Thanks,
Cole

On 01/28/2015 03:59 AM, Anatoly Belikov wrote:
> I got this error when i made few subdirectories in gluster volume, and changed
> <dir path /> in  libvirt pool xml accordingly.
> Here is command line and debug output in attached file:
>  python /usr/share/virt-manager/virt-install  --name=vm3vv --disk
> vol=gluster-pool/vm3vv.qcow2,bus=ide,cache=none --ram=1024 --vcpus=1
> --cdrom=/var/glusterfs/vm_images_and_config/iso/msvs3_12.2.iso --debug
> --network=bridge:br0,model=virtio --noautoconsole >> virtinstall.log 2>&1
>
> gluster-pool.xml is pool definition from /etc/libvirt/storage
>
> 2015-01-27 21:52 GMT+03:00 Cole Robinson <crobinso@xxxxxxxxxx
> <mailto:crobinso@xxxxxxxxxx>>:
>
>     On 01/27/2015 08:10 AM, Anatoly.Belikov.wormblood@xxxxxxxxx
>     <mailto:Anatoly.Belikov.wormblood@xxxxxxxxx> wrote:
>     > From: Anatoly Belikov <wormblood@xxxxxxxxx <mailto:wormblood@xxxxxxxxx>>
>     >
>     > ---
>     >  virtinst/devicedisk.py | 6 +++++-
>     >  1 file changed, 5 insertions(+), 1 deletion(-)
>     >
>     > diff --git a/virtinst/devicedisk.py b/virtinst/devicedisk.py
>     > index ac03716..df2befc 100644
>     > --- a/virtinst/devicedisk.py
>     > +++ b/virtinst/devicedisk.py
>     > @@ -627,7 +627,11 @@ class VirtualDisk(VirtualDevice):
>     >
>     >          path = ""
>     >          if poolxml.source_name:
>     > -            path += poolxml.source_name + "/"
>     > +            path += poolxml.source_name
>     > +            if poolxml.type == poolxml.TYPE_GLUSTER:
>     > +                path += poolxml.source_path
>     > +            if not path.endswith('/'):
>     > +                path += "/"
>     >          path += volxml.name <http://volxml.name>
>     >          self.source_name = path
>     >          self.type = "network"
>     >
>
>     Thanks for the patch. Can you describe how to reproduce this issue? If via
>     virt-install, please provide the full command line and debug output, since I'd
>     like to add a test case that covers this
>
>     Thanks,
>     Cole
>
>     _______________________________________________
>     virt-tools-list mailing list
>     virt-tools-list@xxxxxxxxxx <mailto:virt-tools-list@xxxxxxxxxx>
>     https://www.redhat.com/mailman/listinfo/virt-tools-list
>
>
>
>
> --
> С уважением
> А. Беликов




--
С уважением
А. Беликов
<volume type='network'>
  <name>attemt1.qcow2</name>
  <key>gluster://aldserver2/vm_storage_volume/vm_images_and_config/images/attemt1.qcow2</key>
  <source>
  </source>
  <capacity unit='bytes'>8589934592</capacity>
  <allocation unit='bytes'>2012749824</allocation>
  <target>
    <path>gluster://aldserver2/vm_storage_volume/vm_images_and_config/images/attemt1.qcow2</path>
    <format type='qcow2'/>
    <permissions>
      <mode>0644</mode>
      <owner>0</owner>
      <group>0</group>
    </permissions>
    <timestamps>
      <atime>1422536013.697706834</atime>
      <mtime>1422534532.225655775</mtime>
      <ctime>1422534532.789655798</ctime>
    </timestamps>
    <compat>1.1</compat>
    <features/>
  </target>
</volume>
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list

[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux