Hey, On Tue, Dec 16, 2014 at 01:24:05PM +0000, Daniel P. Berrange wrote: > On Tue, Dec 16, 2014 at 02:02:16PM +0100, Christophe Fergeau wrote: > > Several new dependencies were added with the recent msi installer > > update. > > --- > > mingw-virt-viewer.spec.in | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/mingw-virt-viewer.spec.in b/mingw-virt-viewer.spec.in > > index ea8c20b..599ca8a 100644 > > --- a/mingw-virt-viewer.spec.in > > +++ b/mingw-virt-viewer.spec.in > > @@ -24,12 +24,16 @@ Source0: ftp://virt-manager.org/downloads/virt-viewer/virt-viewer-%{versi > > > > BuildRequires: mingw32-filesystem >= 23 > > BuildRequires: mingw64-filesystem >= 23 > > +BuildRequires: mingw32-glib-networking > > +BuildRequires: mingw64-glib-networking > > I'm not seeing any reference to this in our source tree - where is > it used ? This is what provides File "@prefix@/lib/gio/modules/libgiognutls.dll" which is referenced by data/virt-viewer.nsis.in > > > BuildRequires: mingw32-glib2 >= @GLIB2_REQUIRED@ > > BuildRequires: mingw64-glib2 >= @GLIB2_REQUIRED@ > > BuildRequires: mingw32-gstreamer-plugins-bad-free > > BuildRequires: mingw64-gstreamer-plugins-bad-free > > BuildRequires: mingw32-gstreamer-plugins-good > > BuildRequires: mingw64-gstreamer-plugins-good > > +BuildRequires: mingw32-libgovirt > > +BuildRequires: mingw64-libgovirt > > BuildRequires: mingw32-gtk2 >= @GTK2_REQUIRED@ > > BuildRequires: mingw64-gtk2 >= @GTK2_REQUIRED@ > > BuildRequires: mingw32-libusbx > > @@ -42,6 +46,8 @@ BuildRequires: mingw32-gtk-vnc >= @GTK_VNC1_REQUIRED@ > > BuildRequires: mingw64-gtk-vnc >= @GTK_VNC1_REQUIRED@ > > BuildRequires: mingw32-readline > > BuildRequires: mingw64-readline > > +BuildRequires: mingw32-rest > > +BuildRequires: mingw64-rest > > Is this used directly, or only via libgovirt ? It is already a dep of > mingw*-libgovirt, so unless we directly use it too, we don't need to > list it here. It's not used directly except for a mention of RestProxy in one callback which is only compiled in when libgovirt support is enabled. I'll drop it, thanks. Christophe
Attachment:
pgp7MlCYuk7Tq.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
