Re: [PATCH virt-viewer] display-vnc: set correct window size when vnc is initialized

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thank you for the review, I am sending v2.

Pavel

> 
> Pavel,
> 
> I'd go for a short-log as something like:
> 
> display-vnc: fix zoom-level set by command line
> 
> On Wed, Dec 10, 2014 at 10:39 AM, Pavel Grunt <pgrunt@xxxxxxxxxx>
> wrote:
> > The display is shrinked when connecting to a vnc guest. Also
> > the "zoom" option is not working for vnc guests.
> 
> s/shrinked/shrunk
> 
> > This problem can be solved by emitting "display-desktop-resize"
> > signal when vnc is initialized.
> 
> I'd go for something with more emphasis on the zoom-level problem and
> then describing that it also fixes the shrunk display.
> 
> 
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1170071
> > ---
> >  src/virt-viewer-display-vnc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/virt-viewer-display-vnc.c
> > b/src/virt-viewer-display-vnc.c
> > index 1f7c11b..6605b1b 100644
> > --- a/src/virt-viewer-display-vnc.c
> > +++ b/src/virt-viewer-display-vnc.c
> > @@ -118,6 +118,7 @@ virt_viewer_display_vnc_initialized(VncDisplay
> > *vnc G_GNUC_UNUSED,
> >  {
> >      virt_viewer_display_set_show_hint(display,
> >                                        VIRT_VIEWER_DISPLAY_SHOW_HINT_READY,
> >                                        TRUE);
> > +    g_signal_emit_by_name(display, "display-desktop-resize");
> >  }
> >
> >  static void
> > --
> > 1.9.3
> >
> > _______________________________________________
> > virt-tools-list mailing list
> > virt-tools-list@xxxxxxxxxx
> > https://www.redhat.com/mailman/listinfo/virt-tools-list
> 
> ACK with the changes.
> 
> Best Regards,
> --
> Fabiano Fidêncio
> 

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list





[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux