Re: [PATCH virt-viewer 1/9] spice: use virt_viewer_signal_connect_object

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, Nov 14, 2014 at 11:53 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
ACK to the patch apart from these cosmetic issues. There are still
dozens of calls to g_signal_connect in the codebase after this patch,
why are these special?

There was already a mix of both. No particular reason except that virt_viewer_signal_connect_object() is easier to deal with when handler callback is a object. I was tracking memory issues with Spice, I didn't see the need to replace it elsewhere.


--
Marc-André Lureau
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list

[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux