> -----Original Message----- > From: Giuseppe Scrivano [mailto:gscrivan@xxxxxxxxxx] > Sent: Monday, October 20, 2014 6:20 PM > To: Chen, Hanxiao/陈 晗霄 > Cc: virt-tools-list@xxxxxxxxxx > Subject: Re: [virt-manager PATCH 0/2] fix a shortkey gtk > asserstion warning in fsdetails when combo is invisible > > Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> writes: > > > How to reproduce: > > a) open a lxc-container vm details window > > b) choose a filesystem tag > > c) Alt + o > > > > Chen Hanxiao (2): > > ui: change fs-type label ID from "label18" to "fs-type-title" > > fsdetails: fix a shortkey issue when combo is invisible > > > > ui/fsdetails.ui | 2 +- > > virtManager/fsdetails.py | 18 ++++++++++++++++++ > > 2 files changed, 19 insertions(+), 1 deletion(-) > > wouldn't be better to leave it so we can more easily test for duplicate > shortcuts? Anyway, I've not a strong opinion, so better wait for Cole. > I think leaving a shortkey beside a label looks strange. :) When we test our UI on qemu-kvm, and we could find duplicate shortcuts easily. > (The patch 'ui: change fs-type label ID from "label18" to > "fs-type-title"' can be pushed anyway) I've pushed this one. Thanks, - Chen _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
