On Tue, Oct 07, 2014 at 06:02:30PM +0200, Fabiano Fidêncio wrote: > On Tue, Oct 7, 2014 at 5:42 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> > wrote: > > > On Tue, Oct 07, 2014 at 05:39:48PM +0200, Fabiano Fidêncio wrote: > > > Daniel, > > > > > > > > > > Is this change likely to cause any problem problems with GTK 2 > > > > though ? It looks like we're loosing the stock icon images too > > > > for the menus > > > > > > > > > > You're right about this. > > > What do you suggest? Adding ifdefs to check the GTK version or just > > ignore > > > the warnings for now? > > > > Perhaps the loss of stock icons doesn't matter since IIUC the default > > preferences for GNOME cause menu icons to be hidden. > > > > We are not loosing only menu icons, we are also loosing the icons in the > fullscreen "menu". > So, I will leave it as it is for now instead of adding ifdefs to the code. > Does it work for you? Sure Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
