Re: [virt-viewer PATCH v2] Prefer virDomainOpenGraphicsFD for --attach

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ján Tomko <jtomko@xxxxxxxxxx> writes:

> +#if LIBVIR_CHECK_VERSION(1,2,8)
> +    if ((*fd = virDomainOpenGraphicsFD(priv->dom, 0,
> +                                       VIR_DOMAIN_OPEN_GRAPHICS_SKIPAUTH)) >= 0)
> +        return TRUE;
> +
> +    err = virGetLastError();
> +    if (err && err->code != VIR_ERR_NO_SUPPORT) {
> +        g_debug("Error %s", err->message ? err->message : "Unknown");
> +        return TRUE;
> +    }
> +#endif

Would it make sense to check for the virDomainOpenGraphicsFD function in
configure.ac instead of hard-coding the libvirt version here?

Regards,
Giuseppe

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list





[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux