On Mon, Sep 15, 2014 at 01:27:57PM +0200, Fabiano Fidêncio wrote: > On Mon, 2014-09-15 at 13:25 +0200, Christophe Fergeau wrote: > > Hey, > > > > Why not if we want to let the user unobscure the password. The icon is a > > bit weird though, I would not know what it's about without clicking on > > it. > > Code looks good. > > I loved the icon :-) That's the *only* reason I ended up in file-roller > code, looking for the icon name. > Do you have any suggestion about another icon that could be used? Maybe a padlock if there is such an icon? but I guess ideally we'd dynamically change it depending on whether the text is shown or not, ... so most likely not worth the complication. Christophe
Attachment:
pgpTEF7Px6J1O.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
