Re: [PATCH virt-viewer] wixl: fix major upgrade not installing all files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






On Thu, Jul 24, 2014 at 1:30 PM, Marc-André Lureau <marcandre.lureau@xxxxxxxxx> wrote:
ping


On Fri, Nov 8, 2013 at 9:03 PM, Marc-André Lureau <marcandre.lureau@xxxxxxxxx> wrote:
When upgrading virt-viewer, a few files are missing. After repair, they
are all back again.  The reason for this is explained by the so called
Component Rules, that can be simplified by use "one file per component
and stable id". msitools stable component id was a bit buggy, and is now
fixed in upstream (since v0.93-18-ge395249)

Furthermore, although it's not mandatory for simple cases,
RemoveExistingProducts should be Schedule='afterInstallFinalize', see
also:

http://msdn.microsoft.com/en-us/library/aa371197%28v=vs.85%29.aspx
http://stackoverflow.com/questions/15138731/wix-major-upgrade-not-installing-all-files

ACK!
 

---
 data/virt-viewer.wxs.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/virt-viewer.wxs.in b/data/virt-viewer.wxs.in
index 438f341..d5c2522 100644
--- a/data/virt-viewer.wxs.in
+++ b/data/virt-viewer.wxs.in
@@ -125,7 +125,7 @@
     </Feature>

     <InstallExecuteSequence>
-      <RemoveExistingProducts After="InstallValidate"/>
+      <RemoveExistingProducts After="InstallFinalize"/>
     </InstallExecuteSequence>

     <Icon Id="virt-viewer.ico" SourceFile="../icons/virt-viewer.ico"/>
--
1.8.3.1




--
Marc-André Lureau

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list


--
Fabiano Fidêncio
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list

[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux