On Mon, Jul 14, 2014 at 1:03 PM, Marc-André Lureau
<marcandre.lureau@xxxxxxxxx> wrote:
On Fri, Jul 11, 2014 at 6:43 PM, Jonathon Jongsma
<jjongsma@xxxxxxxxxx> wrote:
Christophe already fixed this issue, i think. But it looks like his
v2 patch didn't get an ACK:
https://www.redhat.com/archives/virt-tools-list/2014-June/msg00273.html
Good point, but this patch just honors G_MESSAGES_DEBUG for older
glib version
This may look good, but it is a change of behaviour (nothing handles
G_MESSAGES_DEBUG in rhel6), so just setting SPICE_DEBUG=1 won't work.
You'll have to set G_MESSAGES_DEBUG on top, I disagree with that.
That's not true. Christophe's change does NOT require G_MESSAGES_DEBUG
to be set. In fact, the patch actively sets this env variable when
--debug is passed (g_setenv("G_MESSAGES_DEBUG", G_LOG_DOMAIN, 1)) so
that the user *doesn't* need to set this variable on newer versions of
glib, just as they didn't need to set it on older versions of glib. So
I don't understand your argument.
However, the patch here correctly brings back spice debug messages.
Please reconsider.
--
Marc-André Lureau
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
