Cole Robinson <crobinso@xxxxxxxxxx> writes: > On 07/03/2014 08:13 AM, Giuseppe Scrivano wrote: >> Add UI elements to display and modify QoS settings in the network >> details. >> >> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1089117 >> > > Some UI bits: > > - I'd use KiB/sec to save some text, rather than spelling it out > - Consistent spacing please: 6 pixels between columns, 3 between rows IIRC > - If the checkboxes are unselected, I'd hide the entire child table > - If a have a shutoff network, unselect > > Functional bits: > > - Trying to set 'floor' gives me: floor attribute isn't supported for > network's bandwidth yet. Not sure how it's expected to be used, maybe we want > to conditionally hide it. > - The libvirt test driver doesn't support the 'define new config on top of > running network, shutdown network, new config takes effect'. That's a libvirt > bug, the test driver isn't handling newDef or INACTIVE_XML, etc. Not blocking > this but something to think on, the sooner that's in the test driver the > easier our lives will be going forward. I am going to send a v2 soon that addresses these comments. I've made the spacing 6 pixels/5 pixels to be consistent with other grids in the network window. I've dropped "floor" from v2. I was undecided for v1 if leave it or not and then I preferred to let libvirt fail until it is properly supported. Thanks, Giuseppe _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
