> -----Original Message----- > From: virt-tools-list-bounces@xxxxxxxxxx > [mailto:virt-tools-list-bounces@xxxxxxxxxx] On Behalf Of Cole Robinson > Sent: Thursday, June 26, 2014 8:40 PM > To: Giuseppe Scrivano; Chen Hanxiao > Cc: virt-tools-list@xxxxxxxxxx > Subject: Re: [virt-manager PATCH v2 2/2] engine: addmethods > for showing config window > > On 06/24/2014 11:13 AM, Giuseppe Scrivano wrote: > > Chen Hanxiao <chen_han_xiao@xxxxxxx> writes: > > > >> On 06/24/2014 07:56 PM, Giuseppe Scrivano wrote: > >>> Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> writes: > >>> > >>>> Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > >>>> --- > >>>> v2: add right-click menu support > >>>> > >>>> virtManager/config.py | 4 ++++ > >>>> virtManager/engine.py | 8 +++++++- > >>>> 2 files changed, 11 insertions(+), 1 deletion(-) > >>> I thought the idea was to have a new item in the right click menu, > >>> something like "Show details", that opens the detail window while the > >>> "Open" item is left unchanged and displays the console. Do you like > >>> this idea? > >>> > >>> Anyway, that is just my opinion, probably you would like to hear more > >>> opinions before change anything :-) > >>> > >> Good idea. > >> But this could not solve double click case Richard worried about. > >> > >> How about adding a new item in right click menu as well as adding > >> a configuareble 'Open' button? > > > > I like the idea of having a configurable "Open" button as well as the > > default action when double clicking on a VM. > > > > TBH I don't really like adding a gsettings preference. Adding a config option > for this is just a bunch of code we have to test and maintain for a use case > that very few people will ever need. Adding a right click option for 'Show > details' is a fine workaround for the original use case, and is useful to > others as well, so I'd recommend just sticking with that. > > Please also test that the original virt-viewer use case actually works with a > 'show details' option, we may unconditionally connect to the console if the > details window is opened, regardless of what screen we switch to. > OK, let's add a right click menu for this. Thanks, - Chen _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
