Hey, ACK, one minor nit below, On Mon, Jun 09, 2014 at 12:34:38PM +0100, Daniel P. Berrange wrote: > Currently supported virt-viewer Windows builds are using the MSI > installer approach. Remove the now-unused & obsolete support for > NSIS installers. Since there's no upgrade path between NSIS and > MSI installers, it will merely cause confusion to have both > continue to be supported. > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > @@ -47,8 +33,7 @@ msi: virt-viewer-$(WIXL_ARCH)-$(VERSION).msi > > CLEANFILES += \ > deps.txt \ > - virt-viewer-$(VERSION).exe \ > - virt-viewer-$(WIXL_ARCH)-$(VERSION).msi \ > + virt-viewer-$(WIXL_ARCH)-$(VERSION).msi \ > $(NULL) Nit: the 'virt-viewer-$(WIXL_ARCH)-$(VERSION).msi' change is unneeded here (it changes a trailing tab to a trailing space). Christophe
Attachment:
pgpDQ1oiiwpzQ.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
