On Mon, Jun 09, 2014 at 07:43:40AM -0400, Marc-André Lureau wrote: > > > @@ -214,19 +214,14 @@ AC_ARG_WITH([buildid], > > AS_HELP_STRING([--with-buildid=id], [Set additional build version > > details]), > > [buildid="-$with_buildid"], [buildid=""]) > > I think it's nicer to have a default value of 0 for buildid here, iirc, windows installer will fail with invalid productversion otherwise. I do actually set a default of 0 on the following lines, but you're right that I could just squash it into this declaration instead to make it simpler > > > AC_DEFINE_UNQUOTED([BUILDID], "$buildid", [Build version details]) > > -if test "x$buildid" != x; then > > - AC_SUBST([BUILDID], "$buildid") > > +if test "x$buildid" = x; then > > + buildid="0" > > fi > > +AC_SUBST([BUILDID], "$buildid") Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
