Re: [virt-manager PATCH] details: use uniformedexpression of "Default"

[Chen Hanxiao <chen_han_xiao@xxxxxxx>]

On 04/14/2014 05:35 PM, Giuseppe Scrivano wrote:
> Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> writes:
>
> > We use both "Default" and "default" for controllers
> > if no controller model needed.
> > They should be the same expression and "Default"
> > is a better choice.
> >
> > Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
> > ---
> >   virtManager/details.py | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/virtManager/details.py b/virtManager/details.py
> > index 3c3a3d2..960cec0 100644
> > --- a/virtManager/details.py
> > +++ b/virtManager/details.py
> > @@ -3046,7 +3046,7 @@ class vmmDetails(vmmGObjectUI):
> >               self.widget("config-remove").set_sensitive(True)
> >   
> >           uiutil.set_combo_entry(self.widget("controller-model"),
> > -                             dev.model or "default")
> > +                             dev.model or "Default")
> >   
> >       def refresh_filesystem_page(self):
> >           dev = self.get_hw_selection(HW_LIST_COL_DEVICE)
> ACK
>
> Giuseppe

Thanks, pushed.

- Chen
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/virt-tools-list


_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list