On 03/30/2014 12:00 AM, Cole Robinson wrote:
On 03/28/2014 02:57 AM, Chen Hanxiao wrote:We could set blank ip address IP setting->Configure->Mode (static), then press "OK". And libvirt will throw an error not very helpful: Error creating interface: 'Could not define interface: XML error: could not get interface XML description: XML invalid - Element protocol failed to validate attributes. This patch will forbid setting an empty ip address. Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> --- virtManager/createinterface.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virtManager/createinterface.py b/virtManager/createinterface.py index 11fc9b2..4588bba 100644 --- a/virtManager/createinterface.py +++ b/virtManager/createinterface.py @@ -764,7 +764,7 @@ class vmmCreateInterface(vmmGObjectUI): def build_ip_info(self): def build_ip(addr_str): if not addr_str: - return None, None + raise ValueError(_("Please enter an IP address")) ret = addr_str.rsplit("/", 1) address = ret[0] prefix = NoneACK to this one - Cole
Thanks, pushed. -Chen
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
