On Wed, Mar 26, 2014 at 07:37:33AM -0400, Cole Robinson wrote:
On 03/26/2014 05:34 AM, Martin Kletzander wrote:On Tue, Mar 25, 2014 at 06:01:20PM -0400, Cole Robinson wrote:On 03/25/2014 10:42 AM, Marc-André Lureau wrote:From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> Hi, This small series implements the "spiceport" channel type. libvirt supports "spiceport" since version 1.2.2. The Spice WebDAV channel allows the client to share a folder with the guest. There is some default configuration to use the "spiceport" type appropriately. (once the guest VM is configured with a WebDAV channel, a small service can be used in the guest to expose a webdav server, that can be mounted, see also http://cgit.freedesktop.org/spice/spice/tree/docs/manual/manual.txt "Folder Sharing") Marc-André Lureau (4): ui: add 'channel' to addhardware char panel addhw: add CharDevice.source_channel addhw: add CharDevice "spiceport" type addhw: fill new char-channel UI tests/xmlparse-xml/change-chars-in.xml | 4 ++++ tests/xmlparse-xml/change-chars-out.xml | 4 ++++ tests/xmlparse.py | 7 +++++++ ui/addhardware.ui | 33 ++++++++++++++++++++++++++++----- virtManager/addhardware.py | 7 +++++++ virtinst/devicechar.py | 18 +++++++++++++++--- 6 files changed, 65 insertions(+), 8 deletions(-)Thanks, I've pushed this. I'm a bit confused though, I understand the virtio-serial channel name maps to /dev/.../<name> in the VM, but what exactly does the source channel map to?Target is '/dev/virtio-serial/<name>', in this case the name is '/dev/virtio-serial/org.spice-space.webdav.0' IIRC and on the source this is a text channel in the spice protocol which the client connected might use. The same way when you do: <serial type='spiceport'> <source channel='org.spice.spicy'/> <target type='isa-serial' port='0'/> </serial> this will get you a connection from the spice client ('org.spice.spicy' text channel) to the guest (/dev/ttyS0 or similar depending on the udev implementation).So in elmarco's patch, use org.spice-space.webdav.0 for the source channel as well. Is this a well known name that spice-gtk knows about, or do you have to tell spice-gtk in some capacity what source port to use, or something else?
If I understand this correctly (I'm not really the best one to answer this), the names are decided and clients should know them. So avvording to the patch, 'org.spice-space.webdav.0' should be the "standard" name for webdav sharing, according to this mail [1] 'org.qemu.console.serial.0' should be standard port name for serial console (although I had to use 'org.spice.spicy' to get the console working with 'spicy'). I'm leaving it up to Marc-André to answer more appropriately with all the details (and fixing all my mistakes in above answers :) ). Martin [1] http://lists.freedesktop.org/archives/spice-devel/2014-January/015919.html
- Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list