Re: [PATCH v2 virt-manager 0/2] show domain state reason

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/19/2014 08:03 AM, Giuseppe Scrivano wrote:
> Giuseppe Scrivano (2):
>   virtManager: read the reason for the domain state
>   virtManager: show the state reason in the VM overview
> 
>  virtManager/details.py |  3 ++-
>  virtManager/domain.py  | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  virtinst/support.py    |  1 +
>  3 files changed, 63 insertions(+), 1 deletion(-)
> 

One suggestion: if the reason isn't in our string table, or the connection
doesn't support the API, I'd rather print 'Shutoff' than 'Shutoff (Unknown)'
since Unknown is a bit ambiguous and potentially scary.

ACK otherwise, feel free to just push with that change if you agree.

Thanks,
Cole

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list




[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux