Re: [PATCH virt-viewer] Silence a message about missing configuration file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ACK

On Wed, Mar 12, 2014 at 02:58:18PM +0100, Marc-André Lureau wrote:
> Do not print a g_debug() error when the configuration file is missing,
> unless given the --debug option.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1006737
> ---
>  src/virt-viewer-app.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> index e134894..f820d8c 100644
> --- a/src/virt-viewer-app.c
> +++ b/src/virt-viewer-app.c
> @@ -1601,8 +1601,11 @@ virt_viewer_app_init (VirtViewerApp *self)
>  
>      g_key_file_load_from_file(self->priv->config, self->priv->config_file,
>                      G_KEY_FILE_KEEP_COMMENTS|G_KEY_FILE_KEEP_TRANSLATIONS, &error);
> -    if (error)
> -        g_debug("Couldn't load configuration: %s", error->message);
> +
> +    if (g_error_matches(error, G_FILE_ERROR, G_FILE_ERROR_NOENT))
> +        DEBUG_LOG("No configuration file %s", self->priv->config_file);
> +    else if (error)
> +        g_warning("Couldn't load configuration: %s", error->message);
>  
>      g_clear_error(&error);
>  
> -- 
> 1.8.5.3
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/virt-tools-list

Attachment: pgpex_i2rAk5n.pgp
Description: PGP signature

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list

[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux