On 02/18/2014 09:54 AM, Chen Hanxiao wrote: > > > On 02/18/2014 10:43 PM, Cole Robinson wrote: >> On 02/18/2014 03:07 AM, Chen Hanxiao wrote: >>> We could config user namespace for LXC >>> when creating a new container. >>> >>> Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> >>> --- >>> ui/create.ui | 185 >>> +++++++++++++++++++++++++++++++++++++++++++++++++- >>> virtManager/create.py | 35 ++++++++++ >>> 2 files changed, 218 insertions(+), 2 deletions(-) >> >> I would rather add this UI to the details->overview page (or maybe a >> 'container' specific page if we think there's more stuff to add here). That >> way we keep the create wizard small, and also allow this stuff to be tweaked >> for existing guests as well. >> > > Add a UI in details->overview is a good choice. > > But I think add one for wizard is not bad as well. > And this patch hide this inside 'Advanced options', > so it would not enlarge the wizard at lots of situations. I don't like adding bits to the create wizard unless it's absolutely necessary, it's just more code to maintain. Especially in the path for LXC guests which is not used anywhere near as much as traditional xen/qemu guests. The reality is also that over time it's unlikely that virt-manager will be a popular tool for creating libvirt-lxc containers, when there's virt-sandbox and eventually docker. So I'd prefer to keep the explicit LXC UI in the create wizard to a minimum. - Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
