> -----Original Message----- > From: Martin Kletzander [mailto:mkletzan@xxxxxxxxxx] > Sent: Monday, February 17, 2014 6:10 PM > To: Chen Hanxiao > Cc: virt-tools-list@xxxxxxxxxx > Subject: Re: [virt-manager PATCH] delete: disable storage > removal by default > > On Mon, Feb 17, 2014 at 01:05:29AM -0500, Chen Hanxiao wrote: > > We should disable storage removal by default > > and let user select it. > > > > We chose to default it to True since there is a confirmation needed > anyway. Look at the commit b2a7c396 (git blame on master on the line > you've changed). > > If you really need it not to be selected by default, please make it > configurable. Although it'll add a lot of unnecessary code :( > > Martin > Thanks for your clarification. The comments above that line really confused me. We don't need to make it configurable thought, but how about change that improper comments to something like: - # Disable storage removal by default + #Enable storage removal by default Thanks _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
