On 02/11/2014 11:29 AM, Eric Blake wrote: > On 02/10/2014 11:58 PM, Chen Hanxiao wrote: >> From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> >> >> Add "-c" as short option of "--connect". >> Replace original "-c" as "-cd" for "--cdrom" > > Ouch. I'm not a fan of long-option names that take only a single '-'. > >> >> This will be much convenient if we operate >> non-default hypervisor. > > Short option convenience is not as importance as backward compatibility. > However, 'virt-install --help | grep -- -c' doesn't mention any use of > -c. So is '-c' as short for '--cdrom' intentionally undocumented? > It's intentional. Historically it was documented. But I'd see this weird error every now and then where people would specify a command line with '-vcpus' instead of '--vcpus'. This mapped to --hvm --cdrom ... and gave weird error messages. It popped up surprisingly often. So we do some funky option parsing to explicitly warn about that case, and the end result is that -c doesn't show up in --help output. - Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
